Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add min max zoom options #197

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Add min max zoom options #197

merged 6 commits into from
Oct 12, 2023

Conversation

etienneburdet
Copy link
Contributor

Summary

The goal for this PR is to add min/max zoom props to the POI maps.

@etienneburdet etienneburdet marked this pull request as ready for review October 10, 2023 07:01
KevinFabre-ods
KevinFabre-ods reviewed Oct 10, 2023
View reviewed changes
Copy link
Contributor

@KevinFabre-ods KevinFabre-ods left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine 👏

IMO we should fully support these two props by reacting to their changes after a map has been mounted.

Currently there behave like map initializer options, not like dynamic props

packages/visualizations-react/stories/Poi/PoiMap.stories.tsx Outdated Show resolved Hide resolved
packages/visualizations/src/components/MapPoi/MapRender.svelte Show resolved Hide resolved
KevinFabre-ods
KevinFabre-ods approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@KevinFabre-ods KevinFabre-ods left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

package.json Outdated Show resolved Hide resolved
@KevinFabre-ods
Copy link
Contributor

Reminder: we need to do a squash merge to keep only one relevant commit

@KevinFabre-ods KevinFabre-ods merged commit a3fbd11 into main Oct 12, 2023
4 checks passed
@KevinFabre-ods KevinFabre-ods deleted the feature/prevent-zooming-out-poi branch October 12, 2023 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinFabre-ods KevinFabre-ods KevinFabre-ods approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@etienneburdet @KevinFabre-ods